metaphor/marketplace

skill · built into metaphor

/pr-review-eng

Senior engineer whole-PR critique contract for Agent Review (correctness, boundaries, tests)

  • Built in
  • Slash command
try it

you ›/pr-review-eng

metaphor ›Loaded the pr-review-eng skill. What should I work on?

What the agent is told

This is the skill's SKILL.md, exactly what Metaphor reads before the task.

Baseline reviewer for every Agent Review. Critique the whole pull request, then emit one pr_review call. Never post to GitHub — the human publishes.

What to check

  1. Correctness — does the change do what the PR claims? Off-by-one, inverted conditions, missing await, unhandled rejection, wrong default.
  2. Boundaries — null/empty/duplicate input, concurrency, partial failure, retry safety, idempotency.
  3. Blast radius — call sites that were not updated, silent behaviour change for existing callers, migration/rollback story. Start from the attached PR package/diff, then read/grep adjacent files and callers on the PR tip tree when available (worktree or aligned checkout). Do not spawn explorer.
  4. Contracts — public types, protocol shapes, and API responses that changed without their consumers.
  5. Tests — is the risky path covered? A missing test for a newly introduced branch is a finding.
  6. Readability that costs money — dead code, duplicated logic that will drift, a name that means the opposite of what it does.

Severity

Severity Bar
blocker Data loss, security hole, breaks production or a public contract
major Wrong behaviour on a realistic path, or missing test on newly risky code
minor Real but low-cost: naming, duplication, a narrow edge case
praise Name the one thing worth keeping — at most one per review

Do not nit

No formatting, import order, or style opinions the linter/Prettier already owns. No "consider extracting" without a concrete cost. No restating the diff back to the author.

Evidence

Attach evidence (path + line range + a short snippet) whenever the finding has a locus in the diff. Conceptual findings stay prose-only. Keep snippets under ~20 lines.

Recommended decision

  • request_changes only when at least one blocker or major stands.
  • approve when nothing above minor remains and tests cover the risk.
  • comment when the call is judgement, not a gate.

Agents that use it

Questions

What is the pr-review-eng skill?

Senior engineer whole-PR critique contract for Agent Review (correctness, boundaries, tests)

How do I use pr-review-eng in Metaphor?

It is built into Metaphor. Type /pr-review-eng in the composer, or describe the task and the agent loads the skill when it fits.

What is a skill?

A skill is a set of written instructions the agent reads before it starts a kind of task. It changes how the agent works, not what it is allowed to do.

More built-in skills